[Bug 796559] qtdemux: Various segment fixes to properly take segment.offset into account

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796559

Alicia Boya García <aboya at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372633|none                        |needs-work
             status|                            |

--- Comment #12 from Alicia Boya García <aboya at igalia.com> ---
Review of attachment 372633:
 --> (https://bugzilla.gnome.org/review?bug=796559&attachment=372633)

Conceptually looks good to me.

Needs a rebase on master, but it may be better to do it after
https://bugzilla.gnome.org/show_bug.cgi?id=752603 is committed to avoid dealing
with min_ts.

Unfortunately, it regresses a couple tests in elements_splitmux, probably
related somehow with reverse playback.

75%: Checks: 8, Failures: 2, Errors: 0
../subprojects/gstreamer/libs/gst/check/gstcheck.c:286:F:caps_change:test_splitmuxsrc_caps_change:0:
Unexpected critical/warning: gst_segment_to_running_time_full: assertion 'stop
!= -1' failed
../subprojects/gstreamer/libs/gst/check/gstcheck.c:286:F:caps_change:test_splitmuxsrc_robust_mux:0:
Unexpected critical/warning: gst_segment_to_running_time_full: assertion 'stop
!= -1' failed

Note gst_segment_get_running_time() requires `stop != -1` when `rate < 0`.
`duration != -1` is not enough (modifying gst_segment_get_running_time_full()
to allow it makes the test pass, but I'm not sure if that's the way to go...
Indeed, we still have no consensus on what GstSegment.duration is about and the
documentation states contradictory information (the duration of the
stream/movie vs the duration of the segment).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.