[Bug 796539] vaapiencoder: (baseclass): wrap in a while loop g_cond_wait() as documented

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Jun 15 09:47:07 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796539

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372663|none                        |needs-work
             status|                            |

--- Comment #7 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 372663:
 --> (https://bugzilla.gnome.org/review?bug=796539&attachment=372663)

thanks a lot for both patches.

Is it possible to merge only one in both branches? to avoid, as possible, the
diversion. 

One more thing, your patches don't follow the gstreamer code stylte:
https://gstreamer.freedesktop.org/documentation/frequently-asked-questions/developing.html#what-is-the-coding-style-for-gstreamer-code

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list