[Bug 795107] Meson: missing option to enable/disable plugins

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795107

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372677|none                        |reviewed
             status|                            |

--- Comment #21 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 372677
  --> https://bugzilla.gnome.org/attachment.cgi?id=372677
Meson: Add feature option each plugin in good

Tri-state options have landed in Meson master, so we can merge this once there
is a new Meson release (0.47.0), as we don't want to depend on Meson from git.

>--- a/ext/meson.build
>+++ b/ext/meson.build
>@@ -1,30 +1,28 @@
>-subdir('aalib')
>-subdir('cairo')
>-subdir('flac')
>-subdir('gdk_pixbuf')
>-subdir('gtk')
>-subdir('jack')
>-subdir('jpeg')
>-subdir('lame')
>-subdir('libcaca')
>-# FIXME: dv plugin fails to link with msvc, wants pthread.lib
>-if cc.get_id() != 'msvc'
>-  subdir('dv')
>-endif
>-subdir('libpng')
>-subdir('mpg123')
>-subdir('raw1394')
>-subdir('qt')
>-subdir('pulse')
>-subdir('shout2')
>-subdir('soup')
>-subdir('speex')
>-# FIXME: taglib fails to compile and link with msvc
>-if cc.get_id() == 'msvc'
>-  message('Building with MSVC, disabling taglib support. Patches welcome!')
>-else
>-  subdir('taglib')
>-endif
>-subdir('twolame')
>-subdir('vpx')
>-subdir('wavpack')
>+plugins = [
>+  'aalib',
>+  'cairo',
>+  'dv',
>+  'flac',
>+  'gdk_pixbuf',
>+  'gtk',
>+  'jack',
>+  'jpeg',
>+  'lame',
>+  'libcaca',
>+  'libpng',
>+  'mpg123',
>+  'pulse',
>+  'qt',
>+  'raw1394',
>+  'shout2',
>+  'soup',
>+  'speex',
>+  'taglib',
>+  'twolame',
>+  'vpx',
>+  'wavpack',
>+]
>+
>+foreach plugin : plugins
>+  subdir(plugin)
>+endforeach

Why are you changing this? This is not an equivalent change, and it's not clear
to me this is really nicer or cleaner or shorter. Can we just keep it as it is
for now? :) (same for gst/meson.build)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.