[Bug 796559] qtdemux: Various segment fixes to properly take segment.offset into account

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796559

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372723|none                        |reviewed
             status|                            |

--- Comment #21 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372723:
 --> (https://bugzilla.gnome.org/review?bug=796559&attachment=372723)

The commit message is wrong, this is mostly about "event" not "element" :)
Otherwise seems fine to me

::: tests/check/elements/filesrc.c
@@ +144,3 @@
   /* reverse seek from end to start */
   gst_element_seek (src, -1.0, GST_FORMAT_BYTES, 0, GST_SEEK_TYPE_SET, 100,
+      GST_SEEK_TYPE_END, 0);

This is very optimistic. I'm surprised it works... and that filesrc is doing
something meaningful with negative rate at all

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.