[Bug 796559] qtdemux: Various segment fixes to properly take segment.offset into account

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796559

--- Comment #23 from Alicia Boya García <aboya at igalia.com> ---
Review of attachment 372723:
 --> (https://bugzilla.gnome.org/review?bug=796559&attachment=372723)

::: gst/gstevent.c
@@ +1267,3 @@
   g_return_val_if_fail (rate != 0.0, NULL);
+  if (rate > 0)
+    g_return_val_if_fail (GST_CLOCK_TIME_IS_VALID (start) ||

Good point. I guess then this check should only be made for GST_SEEK_TYPE_SET,
right? Or would that be wrong too?

I'm supposing doing a GST_SEEK_TYPE_SET to a negative position is not
supported.

::: tests/check/elements/filesrc.c
@@ +144,3 @@
   /* reverse seek from end to start */
   gst_element_seek (src, -1.0, GST_FORMAT_BYTES, 0, GST_SEEK_TYPE_SET, 100,
+      GST_SEEK_TYPE_END, 0);

Well, "it works" may be a overstatement. filesrc does not support reverse
playback... and I don't blame it, as reading a file byte per byte in reverse
order is rarely useful.

I have no idea why is there a `test_reverse` in filesrc in the first place,
given that it does not support reverse playback.

It does not really support GST_SEEK_TYPE_END either. Whenever stop_type !=
GST_SEEK_TYPE_SET it just reads until the end of the file... which keeps the
same behavior before the patch without hitting the new assertion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.