[Bug 796640] qmlglsink: synchronization issue

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796640

--- Comment #14 from jimmy <jipe4153 at gmail.com> ---
(In reply to Nicolas Dufresne (ndufresne) from comment #10)
> Review of attachment 372742 [details] [review]:
> 
> Maybe improve the commit message a bit ? And maybe two commits (optional,
> just proposing).

I was discussing 2 commits, one per file with Jan Schmidt. 

> 
> qttexture: Protect buffer access using a mutext
> qttexture: Wait on the gl fence when using imported buffers
> 
> Don't we need to wait on the fence before the render code ?
There is a discussion on-going regarding the most efficient solution, we might
want to avoid CPU/GPU synchronization, but yeah: ensuring all GL calls are done
before render calls make sense.
> 
> ::: ext/qt/gstqsgtexture.cc
> @@ +75,3 @@
> +
> +
> +
> 
> I don't think these empty lines makes sense.

Agreed!

Thanks

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.