[Bug 788361] audiosink: expose more audioringbuffer vmethods to child sinks

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Jun 26 09:35:55 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=788361

Axel MÃ¥rtensson <axelma at axis.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |axelma at axis.com

--- Comment #12 from Axel MÃ¥rtensson <axelma at axis.com> ---
Created attachment 372822
  --> https://bugzilla.gnome.org/attachment.cgi?id=372822&action=edit
Fix resuming after paused

Hi Philippe,

I took use of your patch to expose the vmethods to child sinks, in my case to
alsasink. The vmethods I wanted to expose was the following; pause, resume and
stop.  

Pause worked as expected, however when using resume, I noticed that the
audioringbuffer never receives a start signal and is therefore stuck in a
waiting state. To solve this I changed in gst_audio_sink_ring_buffer_resume()
to always call gst_audio_sink_ring_buffer_start() and thereby a start signal is
sent to the audioringbuffer.


Best regards,
Axel

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list