[Bug 793441] rtsp-stream: client transport is not updated for multicast clients

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793441

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372691|none                        |reviewed
             status|                            |

--- Comment #50 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 372691:
 --> (https://bugzilla.gnome.org/review?bug=793441&attachment=372691)

This seems like it can be merged with the " Don't reserve multicast address in
the client settings case " patch. Same thing really, or not?

::: gst/rtsp-server/rtsp-stream.c
@@ +1384,3 @@

+  /* multicast and transport specific case */
+  if (multicast && ct->destination != NULL && use_transport_settings) {

What's with the case of !multicast and client settings?
check_address_and_ports() also checks for multicast although it is only ever
called for multicast

@@ +1388,3 @@
+    if (!check_address_and_ports (ct->destination, ct->port.min, ct->port.max,
+          TRUE))
+        goto invalid_client_settings;

Is it actually invalid for a client to specify an odd RTP port and an even RTCP
port?

@@ +1464,3 @@
+  if (!transport_settings_defined)
+    tmp_rtp =
+        g_inet_socket_address_get_port (G_INET_SOCKET_ADDRESS (rtp_sockaddr));

Shouldn't this give the same value if transport_settings_defined, and if not it
would be a bug somewhere?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.