[Bug 796676] playbin3: take only playsink locking in a same thread without taking playbin3 locking
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Jun 27 01:33:49 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=796676
--- Comment #3 from HoonHee Lee <hoonh83.lee at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #2)
> Comment on attachment 372821 [details] [review]
> playbin3: don't take duplicate locking in between playbin3 and playsink
>
> This does not apply anymore to GIT master, the locks are in a different
> function. Can you update the patch?
Sorry, I don't understand what you mean.
I think GST_PLAY_BIN3_LOCK is not needed. Because, there is GST_PLAY_SINK_LOCK
in gst_play_sink_get_subtitle_encoding () function likes PROP_VOLUME, PROP_MUTE
and PROP_SAMPLE.
Can you explain in detail what you mean ?
Thanks.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list