[Bug 796525] v4l2h264enc: when gst-rtsp-server is used in conjunction with v4l2h264enc on an imx6, nobody allocates downstream buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796525

--- Comment #16 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 372813:
 --> (https://bugzilla.gnome.org/review?bug=796525&attachment=372813)

::: sys/v4l2/gstv4l2videoenc.c
@@ +824,3 @@
+   * the caps, because the videoencoder just set encoder->srcpad caps to
+   * state->caps. */
+  if (GST_V4L2_IS_ACTIVE (self->v4l2capture)) {

It's a bit late, we have already done bunch of illegal calls in _negotiate().
decide_allocation is called by the base class implementation of negotiate(). If
negotiate() is called with an self->input_state set, it means we are not being
called from _set_format(). I'm surprise running decide_allocation worked, what
I would do is simply return TRUE in negotiate() if the reason we negotiate is
not a new input format. Replying to reconfigure event is optional anyway. I'll
test this tomorrow and report.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.