[Bug 789475] omx: wait for flush complete and buffers being released when flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789475

--- Comment #13 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Nicolas Dufresne (stormer) from comment #12)
> Though, we should check the the OMX stack have behaved properly and returned
> the buffers that was in the OMX stack. Currently, we don't track this, we
> have no idea which outstanding buffers are in the OMX stack and which one
> are downstream the pipeline.

buf->used = TRUE is supposed to indicate that a buffer is in the OMX stack.
Could we just wait for those?

> In my opinion though, if you received OMX_CommandFlush and the buffers were
> not returned yet, this is an error. What you seems to have fixed here is a
> bug in the Zynq OMX stack.

Agreed that not returning buffers would be a bug in the OMX stack. But iirc,
and according to the commit message, we were hitting a race between the
EventCmdComplete event and the FillThisBufferDone/EmptyBufferDone.
This was causing issues but I don't remember exactly what.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.