[Bug 793236] test:msdkh264enc: get a fail by using attach unit test patch.
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Mar 1 08:21:45 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=793236
--- Comment #9 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #8)
> Review of attachment 368738 [details] [review]:
>
> ::: sys/msdk/gstmsdkenc.c
> @@ +793,3 @@
> + for (;;) {
> + task = thiz->tasks + thiz->next_task;
> + gst_msdkenc_finish_frame (thiz, task, FALSE);
>
> what if gst_msdkenc_finish_frame() fails?
That is like gst_msdkdec_drain in decoder.
There is a message saying "failed to finish the task %p, but keep draining for
the remaining frames".
Do you want to put this message also here?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list