[Bug 792983] tags: regression parsing id3 v2.4 tags with extended header

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=792983

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
            Summary|gst-plugins-base 1.12 fails |tags: regression parsing
                   |to read UTF-8 encoded id3v2 |id3 v2.4 tags with extended
                   |tags                        |header

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Pushed this, with a new unit test for ID3 v2.4 extended headers.

Sorry for the breakage. Will also pick into 1.12.

commit 556bc04f1c8900be7269259b8428c8e19733d470
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Thu Mar 1 12:43:25 2018 +0000

    tests: tags: add unit test for ID3 v2.4 extended headers

    https://bugzilla.gnome.org/show_bug.cgi?id=792983

commit 6f5c9db1cc7b8c70c525198f25aa4085fede2c7f
Author: Edward Hervey <edward at centricular.com>
Date:   Mon Feb 12 16:26:01 2018 +0100

    id3v2: re-fix handling of v2.4 extended headers

    The various id3v2 specs handle the extended header sizes differently
    (because hey, it wouldn't be fun otherwise).

    http://id3.org/id3v2.3.0 states:
    "Where the 'Extended header size', currently 6 or 10 bytes, excludes
     itself."

    http://id3.org/id3v2.4.0-structure states:
      Extended header size   4 * %0xxxxxxx
         Number of flag bytes       $01
         Extended Flags             $xx

       Where the 'Extended header size' is the size of the whole extended
       header, stored as a 32 bit synchsafe integer. An extended header can
       thus never have a size of fewer than six bytes.

    So in id3v2.4.0 it's the *whole* extended header size (a-la ISOBMFF
    atom), whereas in id3v2.3.0 it's the extended header size *excluding*
    those 4 initial bytes.

    And for other versions, god knows..

    Fixes regression introduced in commit da607005.

    https://bugzilla.gnome.org/show_bug.cgi?id=792983

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.