[Bug 793997] GBM backend fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793997

--- Comment #2 from Daniel Stone <daniel at fooishbar.org> ---
(In reply to Daniel Stone from comment #1)
> Daniel: set_window_handle is part of the GstVideoOverlay functionality. This
> is how you can embed a GStreamer video sink inside, say, a Gtk interface.
> set_window_handle() is then called to supply the code with an existing
> window handle. What this handle is, is platform specific. In X, it is a
> Window id.
> 
> Since I do not see why anybody would want to embed GBM buffer objects
> anywhere, I added that comment. I wrote the GBM support with a single
> fullscreen video output in mind, just like the Vivante FB support.

Thanks for the explanation! That makes sense to me.

> As for the rest, thanks for the info! I have one remaining question: do you
> see anything wrong with how the BOs and the page flipping are done in
> draw_cb() ? I think this is proper triple buffering. Do you?

I had a look at it, and I think the way you've done it is fine, yeah.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.