[Bug 793413] msdk: manage mfxFrameSurfaces seperately with other surfacepool.

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Mar 5 19:28:52 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793413

--- Comment #16 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 369316:
 --> (https://bugzilla.gnome.org/review?bug=793413&attachment=369316)

::: sys/msdk/gstmsdkbufferpool.c
@@ +258,3 @@
   if (surface->Data.Locked > 0) {
+    /* We should increase outstanding, but impossible here since it's private.
+     * g_atomic_int_inc (&pool->priv->outstanding);

Whether you don't ever give back any buffer to GstBufferPool, or give them all.
Just don't do a mix. For the first case, have a look at PipeWirePool. The V4L2
pool way is a just a bad idea.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list