[Bug 793103] v4l2: compilation failure with mmap/mmap64 signature miss-match

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793103

--- Comment #26 from Michael Tretter <m.tretter at pengutronix.de> ---
(In reply to Nicolas Dufresne (stormer) from comment #24)
> Review of attachment 369428 [details] [review]:
> 
> The new patch uses system defines signature, and wrap libv4l2 if needed. The
> code in libv4l2 is already failing on 32bit off_t if it overflow.

Correct, but the detection of off_t is still wrong. This check is needed in
addition to the libv4l2 wrapper to correctly use mmap64 on 32bit arch, if the
glibc has largefile support. Without the patch, off_t on 32bit arch is always
32bit even though the glibc supports 64bit off_t. You want to have both
patches: the check for largefile support in the glibc and correct handling if
off_t is 32 bits.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.