[Bug 794215] New: segment: Change back gst_segment_do_seek() to use gint64

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794215

            Bug ID: 794215
           Summary: segment: Change back gst_segment_do_seek() to use
                    gint64
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: nicolas at ndufresne.ca
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

During 0.11 dev at commit bdbc069348 the gst_segment_do_seek() was changed to
accept only unsigned start/stop. Though, the code will do direct comparision
with -1 and also assumes negative values for GST_SEEK_TYPE_END:

  start = segment->duration + start;

Additionally, the gst_event_new_seek() API along with the GstElement API uses
signed integer. Demuxers will pass these value unchecked to that API in order
to update their segment. Looking at the code, it will properly wrap around
resulting in the same behaviour, but it's all a bit of a lie. As this does not
affect the API, I think it's fine to switch it back to gint64.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.