[Bug 793865] msdk: encode to wrong color with I420 input.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793865

sreerenj <bsreerenj at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369477|none                        |needs-work
             status|                            |

--- Comment #8 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 369477:
 --> (https://bugzilla.gnome.org/review?bug=793865&attachment=369477)

::: sys/msdk/gstmsdkvideomemory.c
@@ +173,3 @@

+  /* For msdk doesn't support I420 format, we need to swap U/V plane's
pointer. */
+  if (meta->format == GST_VIDEO_FORMAT_I420 && plane ==0) {

Wrong, it is completely legit to invoke this method only for plane 1 & 2 only.
For eg: the downstream element trying to get only the U component for checksum
analysis.

@@ +177,3 @@
+    SWAP_UINT (mem_id->image.pitches[1], mem_id->image.pitches[2]);
+}
+

This changes the actual image offset which is not a good way to handle it.
Because the underlined VAImage still keeping YV12 format. Ideally we should do
something similar to gstremaer-vaai by keeping an alternate image. But for now,
you may just return the swapped offset and pitch without altering the
underlined VAImage structure.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.