[Bug 794216] allocators: Add DMABuf synchronization

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Mar 14 09:19:39 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=794216

--- Comment #6 from Guillaume Desmottes <gdesmott at gnome.org> ---
Review of attachment 369532:
 --> (https://bugzilla.gnome.org/review?bug=794216&attachment=369532)

::: gst-libs/gst/allocators/gstdmabuf.c
@@ +35,3 @@
  */

+#ifdef HAVE_LINUX_DMA_BUF_H

Assuming you tested using meson, did you check that's the exact name defined by
AC_CHECK_HEADERS()?

@@ +87,3 @@
+
+  if (ioctl (gst_fd_memory_get_fd (gmem), DMA_BUF_IOCTL_SYNC, &sync) < 0)
+      GST_WARNING_OBJECT (allocator, "Failed to synchronize DMABuf: %s (%i)",

Is it mandatory for drivers to implement this ioctl? Just to be sure we are not
going to introduce loads of WARNING to existing working code.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list