[Bug 794216] allocators: Add DMABuf synchronization

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794216

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Guillaume Desmottes from comment #6)
> Review of attachment 369532 [details] [review]:
> 
> ::: gst-libs/gst/allocators/gstdmabuf.c
> @@ +35,3 @@
>   */
>  
> +#ifdef HAVE_LINUX_DMA_BUF_H
> 
> Assuming you tested using meson, did you check that's the exact name defined
> by AC_CHECK_HEADERS()?

Yes, AC will capitalize and replace non letters to _, I've mimic this in Meson
to make it match.

> 
> @@ +87,3 @@
> +
> +  if (ioctl (gst_fd_memory_get_fd (gmem), DMA_BUF_IOCTL_SYNC, &sync) < 0)
> +      GST_WARNING_OBJECT (allocator, "Failed to synchronize DMABuf: %s
> (%i)",
> 
> Is it mandatory for drivers to implement this ioctl? Just to be sure we are
> not going to introduce loads of WARNING to existing working code.

The ioctl is implemented in the code. It is a no-op that succeed. Its not clear
why it would fail, but Tim was wondering if we could make the warning trigger
only once. The memory will be valid if it fails, but it's coherency will be
undefined for dma transfer.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.