[Bug 794331] log_omx_performance: GstOMXBuffer and OMX-buffer fields always displayed as NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794331

--- Comment #3 from Guillaume Desmottes <gdesmott at gnome.org> ---
(In reply to Tim-Philipp Müller from comment #2)
> So in this code we're creating a structure and printing that so that a log
> parser can easily deserialise it right?

Yep.

> How about instead of using a temporary GstStructure and printing it via
> GST_PTR_FORMAT, we just print the entire thing in GST_CAT_TRACE_OBJECT() in
> a format that can be deserialised later? It's not like we have complicated
> fields here such as strings that need to be escaped or such?

That was my initiale approach but I switched to GstStructure as we already have
from/to string API saving to re-implement them in gst-omx and log parsers.

I think the first question is: should gst_structure_to_string() handle
pointers? There is a FIXME about that:
https://cgit.freedesktop.org/gstreamer/gstreamer/tree/gst/gststructure.c#n1833

If yes then it makes sense to fix it and keep using it here.
If not we can either convert to string (my patch) or manually display each
field. I don't have a strong opinion here but still think we should re-use
existing serialization code if possible.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.