[Bug 752213] tee: Avoid race condition while forwarding sticky events

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752213

--- Comment #56 from Miguel París Díaz <mparisdiaz at gmail.com> ---
Hello @stormer and @ocrete,
first of all thanks for you feedback.

Answering @stormer questions:
> Does it passes all tests without deadlock?
  Yes, unit tests pass in all projects (gstreamer, gst-plugins-XYZ, etc.)

> Did you run gst-validate?
  How I can run it?

> Can you provide a unit test that triggers the race?
  Make a deterministic unit test is quite complex, but if you take a look at my
explanation about the race condition, it is quite clear that it exist.

> This patch is very scary, specially that the is no doc in the commit to explain what it is fixing and why it won't cause issues.
First of all we all need to agree about the solution. For now you can take this
issue thread as doc, where all details are discussed.

Answering @ocrete:
> I think this could block at the sink on a preroll if it's a GAP event
Could you please put an example?

In addition, I would like to mention that this patch is running in our
production environment (since more than one year ago) fixing the race condition
and we didn't notice any deadlock.
Anyway, it might have a deadlock that is not reproducible in our use case.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.