[Bug 794507] waylandsink: gstbuffer which made by waylandsink buffer pool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794507

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #369886|none                        |rejected
             status|                            |

--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 369886:
 --> (https://bugzilla.gnome.org/review?bug=794507&attachment=369886)

I cannot make any sense of this commit message. Can you rewrite this, and add a
longer explanation ?

::: ext/wayland/gstwaylandsink.c
@@ +585,3 @@
+    config = gst_buffer_pool_get_config (sink->pool);
+    gst_buffer_pool_config_get_params (config, NULL, &size, &min_bufs,
+        &max_bufs);

That make no sense. The pool does not know the caps, how could it know it's
buffer size ?

@@ +589,1 @@
+    gst_query_add_allocation_pool (query, sink->pool, size, min_bufs,
max_bufs);

sink->pool is private and internal. The only use for this pool is to copy
incoming buffers when they are not suitable for the Wayland protocol (not from
wayland pool, FD base, or dmabuf). Sharing this pool with upstream is unsafe.

@@ +589,2 @@
+    gst_query_add_allocation_pool (query, sink->pool, size, min_bufs,
max_bufs);
+    gst_query_add_allocation_param (query, gst_tizen_wl_shm_allocator_get (),

Right, gst_tizen .... I guess you should submit your patch to the related
downstream fork ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.