[Bug 793705] msdk: Implement Video Post Processing element
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Mon Mar 26 20:49:27 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=793705
--- Comment #11 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Hyunjun Ko from comment #10)
> Review of attachment 370068 [details] [review]:
>
> ::: sys/msdk/gstmsdkvpp.c
> @@ +339,3 @@
> + if (caps)
> + gst_caps_unref (caps);
> +
>
> Doesn't need to unref the caps. Otherwise it might cause an error like this.
> (gst-launch-1.0:23029): GStreamer-CRITICAL **: gst_mini_object_unref:
> assertion 'GST_MINI_OBJECT_REFCOUNT_VALUE (mini_object) > 0' failed
>
> @@ +795,3 @@
> +static GstCaps *
> +gst_msdkvpp_fixate_caps (GstBaseTransform * trans,
> + GstPadDirection direction, GstCaps * caps, GstCaps * othercaps)
>
> This vmethod takes ownership of othercaps.
> You need to unref this caps.
Thank you for catching those!
I will fix both of them in next iteration.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list