[Bug 794069] gtk-doc output does not build reproducibly

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794069

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.12.5

--- Comment #1 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks for the bug report, the analysis and the patch!

I understand why "sort" makes sense for reproducible builds, but what I don't
entirely understand is what exactly caused the flip-flopping of the output. The
order in inspect_files should not really affect the output in principle.

It looks to me like the real underlying problem is that some plugins got
renamed and there are some stale files in docs/plugin/inspect/, e.g. we have
both

  docs/plugin/inspect/plugin-gstgtk.xml (outdated)
  docs/plugin/inspect/plugin-gtk.xml (current)

and sort just makes it stable, but it might still pick up the wrong/outdated
version of the file in this case.

Same for the "rawparse" plugin which got moved to -base and renamed to
"legacyrawparse".

I think the real fix is to delete the stale files.

I have pushed this to the 1.12 branch which will be in 1.12.5:
commit a5db934b88a520f414783fdc9d064a6382d691dc
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Tue Mar 27 19:49:17 2018 +0100

    docs: plugins: remove stale inspect xml files

    gtk plugin was renamed (gstgtk -> gtk) and rawparse
    was moved to -base, with legacyrawparse remaining.

    https://bugzilla.gnome.org/show_bug.cgi?id=794069


and similar things to 1.14 and git master (gtk plugin has moved to good), so it
should hopefully be fixed in the 1.14.1 release and onwards.

There's nothing wrong with your patch of course, but it really shouldn't be
needed, so I'm leaving it for now.

Please re-open if it's still a problem, thanks!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.