[Bug 793707] msdk: Add dmabuf support in msdk plugins
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Mar 27 23:33:56 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=793707
sreerenj <bsreerenj at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #370042|none |reviewed
status| |
--- Comment #12 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 370042:
--> (https://bugzilla.gnome.org/review?bug=793707&attachment=370042)
::: sys/msdk/gstmsdkdec.c
@@ +423,3 @@
+
+ if (gst_msdk_find_preferred_caps_feature (thiz,
+ GST_CAPS_FEATURE_MEMORY_DMABUF))
This routine is not for finding preferred capsfeatures, rather it just checking
whether downstream has support for DMABufCapsFeatures.
It could be useful in future for checking other capsfeatures too but for now,
it is confusing. Could you please change the function name?
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list