[Bug 794773] buffer: gst_buffer_copy_into should not copy parent buffer metas when doing a deep copy
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed Mar 28 18:05:48 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=794773
Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #370250|none |needs-work
status| |
--- Comment #1 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 370250:
--> (https://bugzilla.gnome.org/review?bug=794773&attachment=370250)
::: gst/gstbuffer.c
@@ -629,2 +629,4 @@
"don't copy memory meta %p of API type %s", meta,
g_type_name (info->api));
+ } else if (flags & GST_BUFFER_COPY_DEEP
+ && meta->info->api == GST_PARENT_BUFFER_META_API_TYPE) {
We should not check for one specific meta, but base our decision
gst_meta_api_type_has_tag(... , something) like we do elsewhere. This way, if
third party adds meta that also should not be copied in deep_copy, it can.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list