[Bug 794793] waylandsink: change to use GCond to avoid dropping video buffer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Mar 29 12:07:31 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=794793

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #370283|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 370283:
 --> (https://bugzilla.gnome.org/review?bug=794793&attachment=370283)

I'm not convinced by this solution, since you might be playing something like
60fps over 30fps display. This method will add one vblank latency that isn't
needed. Also, you have a bug, since you need to unblock on state transition to
READY and on flush-start event.

The is a branch that started implementing presentation timestamp support, that
seems much more robust solution.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list