[Bug 794794] rtpssrcdemux: add the support of buffer list

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794794

--- Comment #6 from Eloi BAIL <eloi.bail at savoirfairelinux.com> ---
Review of attachment 370285:
 --> (https://bugzilla.gnome.org/review?bug=794794&attachment=370285)

::: gst/rtpmanager/gstrtpssrcdemux.c
@@ +159,3 @@
+  GstPad *src_pad;
+  GstBufferList *buffer_list;
+};

yes. Please see my fix in
0002-fixup-rtpssrcdemux-add-the-support-of-buffer-list.patch

@@ +181,3 @@
+{
+  GstRtpSsrcBufferList *elem_buf_list;
+  elem_buf_list = g_new0 (GstRtpSsrcBufferList, 1);

This code is now removed because GstRtpSsrcDemuxPad struct is used

@@ +222,3 @@
+  for (walk = demux->ssrc_buffer_list; walk; walk = g_slist_next (walk)) {
+    GstRtpSsrcBufferList *list = (GstRtpSsrcBufferList *) walk->data;
+    GST_INFO_OBJECT (demux, "SSRC %08x: pushing %u buffers", list->ssrc,

please see the fix in
0002-fixup-rtpssrcdemux-add-the-support-of-buffer-list.patch

@@ +224,3 @@
+    GST_INFO_OBJECT (demux, "SSRC %08x: pushing %u buffers", list->ssrc,
+        gst_buffer_list_length (list->buffer_list));
+    gst_pad_push_list (list->src_pad, list->buffer_list);

please see the fix in
0004-rtpssrcdemux-use-flowcombiner-for-gst_pad_push_list.patch

@@ +756,3 @@
+
+  push_all_buffer_list (demux);
+  return ((ret == TRUE) ? GST_FLOW_OK : GST_FLOW_ERROR);

please see the fix in
0002-fixup-rtpssrcdemux-add-the-support-of-buffer-list.patch

@@ +767,3 @@
+  demux = GST_RTP_SSRC_DEMUX (parent);
+  ret = gst_rtp_ssrc_demux_handle_buffer (demux, buf, FALSE);
+  return ret;

fixed in 0002-fixup-rtpssrcdemux-add-the-support-of-buffer-list.patch

::: gst/rtpmanager/gstrtpssrcdemux.h
@@ +43,3 @@
   GRecMutex padlock;
   GSList *srcpads;
+  GSList *ssrc_buffer_list;

it is now in GstRtpSsrcDemuxPad. See
0002-fixup-rtpssrcdemux-add-the-support-of-buffer-list.patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.