[Bug 778426] qtdemux: Properly handle edit list in push mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=778426

--- Comment #15 from Alicia Boya García <aboya at igalia.com> ---
Review of attachment 345400:
 --> (https://bugzilla.gnome.org/review?bug=778426&attachment=345400)

r+

::: gst/isomp4/qtdemux.c
@@ +6431,3 @@
             demux->got_moov = TRUE;
+            if (demux->fragmented) {
+              /* fragmented streams headers shouldn't contain edts atoms */

Fragmented streams can (and often should) contain edts atoms. Nevertheless,
that is better changed in a different patch, after edts.duration=0 support is
added, which is often used in fragmented files.

@@ +6434,3 @@
+              gst_qtdemux_check_send_pending_segment (demux);
+            } else {
+              gst_event_replace (&demux->pending_newsegment, NULL);

This line makes me wonder... Why are we setting demux->pending_newsegment in
the first place?

demux->pending_newsegment is loaded with the movie (unedited) playback range,
which should never be emitted by the srcpads. Instead, the requested movie
position should be mapped to an edit, like the following line does.

(This is a reflection about qtdemux, not a problem with this particular patch.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.