[Bug 793705] msdk: Implement Video Post Processing element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793705

--- Comment #23 from sreerenj <bsreerenj at gmail.com> ---
Review of attachment 370068:
 --> (https://bugzilla.gnome.org/review?bug=793705&attachment=370068)

::: sys/msdk/gstmsdkvpp.c
@@ +437,3 @@
+
+static MsdkSurface *
+get_msdk_surface_from_input_buffer (GstMsdkVPP * thiz, GstBuffer * inbuf)

Well, MsdkSurface itself is not needed unless we wanna support Async-depth > 1.
Not sure whether it makes really sense to add Async-depth to vpp.

@@ +515,3 @@
+    if (status != MFX_WRN_DEVICE_BUSY)
+      break;
+    /* If device is busy, wait 1ms and retry, as per MSDK's recomendation */

Will fix it :)

@@ +533,3 @@
+    status = MFX_ERR_NONE;
+
+  gst_buffer_copy_into (outbuf, inbuf, GST_BUFFER_COPY_TIMESTAMPS, 0, -1);

Yup, we need to take few more stuff from gst-vaapi. Will do it in another
patch. thanks.

@@ +701,3 @@
+    thiz->param.NumExtParam = thiz->num_extra_params;
+    thiz->param.ExtParam = thiz->extra_params;
+  }

Aha, messed up the rebase I think ! Will fix it.

GArray, well, maybe in the next iteration :), same could be needed for encoder
too.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.