[Bug 795391] vaapi: problems when playing with glimagesink with egl

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795391

--- Comment #31 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #30)
> (In reply to Hyunjun Ko from comment #29)
> > (In reply to Víctor Manuel Jáquez Leal from comment #11)
> > > 
> > > ::: gst/vaapi/gstvaapipluginutil.c
> > > @@ +211,3 @@
> > > +      GstGLDisplayEGL *egl_display;
> > > +
> > > +      egl_display = gst_gl_display_egl_from_gl_display (gl_display);
> > > 
> > > why not call here too gst_gl_display_get_handle() thus you could get a
> > > common guintptr variable, which could be null by default.
> > > 
> > 
> > There are different cases.
> > If there's a gldisplaywayland in glcontextegl, in this case, we should call
> > gst_gl_display_egl_from_gl_display to retrieve EGLDisplay.
> > (This is the case that's using gst-play or totem.)
> > 
> > But if gldisplayegl in glcontextegl, we can use just
> > gst_gl_display_get_handle.
> > (This is the case that's in WebkitGTK.)
> 
> You can see my patch in attachment 371465 [details] [review] and use the
> variable display_type to decide which API call use.

hmm.. that wouldn't be simple imo.
(just using gst_gl_display_egl_from_gl_display VS using 2 apis by conditional
statement)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.