[Bug 795551] Sporadic stall during seeking on Gstreamer 1.10.4 and higher

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed May 2 16:21:24 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=795551

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.14.1

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
The appsink specific commits should probably also go into 1.14, the other is a
new regression in master.


commit dbd9ff1cf5108aeb51e1559222f386eb85d2abd2 (HEAD -> master, origin/master,
origin/HEAD)
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed May 2 18:39:31 2018 +0300

    appsink: Handle unlock in drain query handling too

    And also handle flushing, we might otherwise wait here forever when
    flushing too.

commit 9f9000e693694ea33c21607140ffc29aa1734062
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed May 2 18:35:23 2018 +0300

    appsink: Make sure to also handle unlock when waiting for EOS to be handled

    Otherwise shutting down during EOS waiting will cause a deadlock.

    https://bugzilla.gnome.org/show_bug.cgi?id=795551

commit a19497ab67cf9517fb12f2bf30e034078d36a958
Author: Sebastian Dröge <sebastian at centricular.com>
Date:   Wed May 2 18:11:58 2018 +0300

    appsrc/sink: Fix optimization for only signalling waiters if someone is
actually waiting

    It is possible that both application and the stream are waiting
    currently, if for example the following happens:
      1) app is waiting because no buffer in appsink
      2) appsink providing a buffer and waking up app
      3) appsink getting another buffer and waiting because it's full now
      4) app thread getting back control

    Previously step 4 would overwrite that the appsink is currently waiting,
    so it would never be signalled again.

    https://bugzilla.gnome.org/show_bug.cgi?id=795551

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list