[Bug 630441] baseaudiosink: Newly added sinks don't get notified about the bin's latency

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri May 4 14:01:09 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=630441

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #20 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
I think this needs a test even if the patch is old. Somehow, elements exposing
latency should be posting latency messages to their parent. The application is
responsible for redistributing the latency (gst_bin_recalculate_latency()).

The important thing here, is that the latency that get applied (through latency
event) might not match the latency that an element would query. This is because
the latency distributed will be the highest latency obtained by querying each
sinks, and this is important if you care about a/v sync.

Right now, we clearly recalculate latency on state change to PLAYING, I'm not
sure if we have a mechanism for dynamically added element. But clearly, the
solution should be around having th message being posted. The Pipeline should
probably drop this message if sent in PAUSED (or less) state, as it will
recalculate once anyway.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list