[Bug 747217] dtlssrtpenc/dec: Should reset its state when going back to NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747217

Olivier Crête <olivier.crete at ocrete.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #311036|none                        |reviewed
             status|                            |

--- Comment #3 from Olivier Crête <olivier.crete at ocrete.ca> ---
Review of attachment 311036:
 --> (https://bugzilla.gnome.org/review?bug=747217&attachment=311036)

::: ext/dtls/gstdtlssrtpdec.c
@@ +442,3 @@
+  }
+
+  bin->dtls_element = gst_element_factory_make ("dtlsdec", "dtls-decoder");

Can you leave the name as NULL because having specific names makes it harder to
grep through debug logs.

@@ +456,3 @@
+
+  g_signal_connect (bin->dtls_element, "notify::peer-pem",
+      G_CALLBACK (on_peer_pem), self);

Don't you want to connect the signal before you link the pads ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.