[Bug 794401] glvideomixer: possible rotation bug

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=794401

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371377|none                        |needs-work
             status|                            |

--- Comment #5 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 371377:
 --> (https://bugzilla.gnome.org/review?bug=794401&attachment=371377)

Almost.

::: ext/gl/gstglvideomixer.c
@@ +1554,3 @@
           gst_buffer_get_video_affine_transformation_meta (vagg_pad->buffer);
       gst_gl_get_affine_transformation_meta_as_ndc_ext (af_meta, matrix);
+      gst_gl_multiply_matrix4(matrix, pad->m_matrix, matrix);

In-place multiplication most likely doesn't work correctly for all cases.  Keep
the result in a temporary.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.