[Bug 751605] audio: Add proper support for non-interleaved / planar audio

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751605

--- Comment #16 from George Kiagiadakis <gkiagia at tolabaki.gr> ---
(In reply to Sebastian Dröge (slomo) from comment #15)
> Review of attachment 371717 [details] [review]:
>
> @@ +151,3 @@
> +  gint        n_planes;
> +  gsize       plane_size;
> +  gpointer    *planes;
> 
> Planes? Or should it rather be channels?

Hmm, it's not channels because you can also use this struct to map an
interleaved buffer (which has 1 plane). And this is useful if you want to have
a uniform way to access data in both layouts.

> @@ +158,3 @@
> +
> +  gpointer    priv_planes_arr[8];
> +  GstMapInfo  priv_map_info_arr[8];
> 
> We might want to map only once if it's only a single memory... but that's an
> optimization for later times

If you look at the code, I just map once. The rest of the map infos are unused.
I don't think it's allowed to map multiple times the same memory. Iirc there
are locks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.