[Bug 684790] isomp4/qtdemux: Whenever a moov atom is found, restart the demuxer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=684790

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371794|none                        |needs-work
             status|                            |

--- Comment #78 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 371794:
 --> (https://bugzilla.gnome.org/review?bug=684790&attachment=371794)

::: gst/isomp4/qtdemux.c
@@ +2573,3 @@
   gst_tag_list_unref (stream->stream_tags);
   if (stream->pad) {
+    GstElement *qtdemux = gst_pad_get_parent_element (stream->pad);

This is inefficient. Just store the qtdemux object in a stream field.

@@ +2575,3 @@
+    GstElement *qtdemux = gst_pad_get_parent_element (stream->pad);
+
+    if (G_UNLIKELY (!qtdemux)) {

This should never happen (and will go away once you store it in the stream)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.