[Bug 795560] Playbin3 pipeline is pending when trick play (-2x) with NO AUDIO TRICKMODE

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=795560

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371409|none                        |needs-work
             status|                            |

--- Comment #2 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 371409:
 --> (https://bugzilla.gnome.org/review?bug=795560&attachment=371409)

::: gst-libs/gst/audio/gstaudiodecoder.c
@@ +1243,3 @@

+  /* FIXME: Sending new Segment and GAP event for NO AUDIO TRICKMODE */
+  if (dec->input_segment.flags & GST_SEGMENT_FLAG_TRICKMODE_NO_AUDIO) {

why not the output segment ?

@@ +1251,3 @@
+        GST_SEGMENT_FORMAT, &dec->input_segment, &dec->output_segment);
+
+    output_seg = gst_pad_get_sticky_event (dec->srcpad, GST_EVENT_SEGMENT, 0);

why not just use the audiodecoder->output_segment ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.