[Bug 775045] gtkglsink: re parenting the video widget into a different toplevel does not work

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=775045

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371869|none                        |needs-work
             status|                            |

--- Comment #5 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 371869:
 --> (https://bugzilla.gnome.org/review?bug=775045&attachment=371869)

The other part: changing the display/context used by the pipeline requires some
thinking/design work as the GstContext machinery does not have support for
that.

The easiest thing I can come up with is to add a 'resource-destroyed'-like
signal on both GstGLDisplay and GstGLContext where on emission each user
attempts to retrieve a new GstGLDisplay/GstGLContext.

::: ext/gtk/gtkgstglwidget.c
@@ +377,3 @@
+  if (!priv->other_context) {
+    GTK_GST_BASE_WIDGET_UNLOCK (gst_widget);
+    gst_gtk_invoke_on_main ((GThreadFunc) _get_gl_context, gst_widget);

Aren't we always called on the main thread already from GtkWidget?

@@ +388,3 @@
+
+  if (priv->context)
+    retval = gst_gl_display_add_context (priv->display, priv->context);

retval isn't declared or used.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.