[Bug 684790] isomp4/qtdemux: Whenever a moov atom is found, restart the demuxer

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 10 08:04:52 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=684790

--- Comment #93 from Seungha Yang <pudding8757 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #92)
> (In reply to Seungha Yang from comment #88)
> > Created attachment 371849 [details] [review] [review]
> > [3/9] qtdemux: Use GList to manage QtDemuxStream
> > 
> > * Move to GList from static array
> > * Logging track-id instead of array index. It's more meaningful.
> 
> Why a GList instead of a GArray or GPtrArray? Unless you need to
> remove/insert elements in the middle/beginning, the latter is usually more
> efficient in all regards.

Actually qtdemux might need remove any streams in the middle or beginning.
https://cgit.freedesktop.org/gstreamer/gst-plugins-good/tree/gst/isomp4/qtdemux.c#n12197

 I thought that streams in a mp4 file is not bulky and therefore 
GList will not bring much overhead over GPtrArray. If we'd like to change to
GPtrArray, I think it's not difficult though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list