[Bug 781393] tsdemux: fix to keep seqnum of segment

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat May 12 07:09:24 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=781393

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350113|none                        |needs-work
             status|                            |

--- Comment #5 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 350113:
 --> (https://bugzilla.gnome.org/review?bug=781393&attachment=350113)

Definitely good and needed.

Only nitpick. Could you use GST_SEQNUM_INVALID for initialization and checking
whether it is valid ? This makes the code clearer.

And could you rebase it against current master ? Thanks !

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list