[Bug 796043] subparse: out-of-bounds array access when fixing SubRip markup

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796043

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #371963|none                        |accepted-commit_now
             status|                            |

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 371963:
 --> (https://bugzilla.gnome.org/review?bug=796043&attachment=371963)

::: gst/subparse/gstsubparse.c
@@ -818,3 +821,3 @@
         if (num_open_tags == 0
-            || g_ascii_strncasecmp (end_tag - 1, open_tags[num_open_tags - 1],
-                strlen (open_tags[num_open_tags - 1]))) {
+            || !g_ptr_array_find_with_equal_func (open_tags, tag_name,
+                g_str_equal, &index)) {

I always have doubt about the use of g_str_equal outside GHashTable, otherwise
looks good I think.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.