[Bug 707433] xvid: Port plugin to 1.0.
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Wed May 16 16:57:33 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=707433
Edward Hervey <bilboed at bilboed.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #371972|none |needs-work
status| |
--- Comment #7 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 371972:
--> (https://bugzilla.gnome.org/review?bug=707433&attachment=371972)
Only went through the decoder
::: ext/xvid/gstxviddec.c
@@ +120,3 @@
+
+/* flush xvid encoder buffers caused by bframe usage;
+ disabled for now... */
is this because the xvid library can't support it ?
@@ +202,3 @@
+ }
+
+ /* and pass along all */
you don't need to implement ::parse() if you just pass along everything
@@ +297,3 @@
+ info->width, info->height, dec->input_state);
+
+ /* FIXME : Do we still need to set fps/par now that we pass the reference
input stream ? */
no
@@ +410,3 @@
+ /* bframes can cause a delay in frames being returned
+ non keyframe timestamps can permute a bit between
+ encode and display order, but should match for keyframes */
all this ts handling should be needed. Doesn't xvid have a way to provide an
identifier of some kind on input and then provide you that identifier on the
decoded frame ?
That would allow you to match the proper data on the output buffer.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list