[Bug 796382] flvmux: (too) easily produces backwards flv-timestamps

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 24 12:22:24 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796382

--- Comment #5 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 372380:
 --> (https://bugzilla.gnome.org/review?bug=796382&attachment=372380)

Indeed, there is no good reason this would not be going forward.

::: tests/check/elements/flvmux.c
@@ +645,3 @@
+    guint32 pts;
+    gst_buffer_map (buf, &map, GST_MAP_READ);
+    pts = GST_READ_UINT24_BE (map.data + 4);

You should maybe add a comment on why you can ignore the TimestampExtented 8
bit.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list