[Bug 796354] wasapi: playback noise

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu May 24 10:55:56 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796354

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372378|none                        |reviewed
             status|                            |

--- Comment #21 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 372378:
 --> (https://bugzilla.gnome.org/review?bug=796354&attachment=372378)

::: sys/wasapi/gstwasapisink.c
@@ +647,2 @@
+    if (have_frames > can_frames) {
+      dwWaitResult = WaitForSingleObject (self->event_handle, INFINITE);

What happens if we only wait if there's no available space at all, and just
write out whatever we can otherwise?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list