[Bug 796389] gst-validate-launcher: Stop in --gdb by default, add --gdb-non-stop

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796389

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372392|none                        |reviewed
             status|                            |

--- Comment #3 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 372392:
 --> (https://bugzilla.gnome.org/review?bug=796389&attachment=372392)

::: validate/launcher/main.py
@@ +460,3 @@
                         action="store_true",
                         help="Run the tests inside gdb (implies"
                         " --output-dir=stdout and --jobs=1)")

Is the test timeout UNLIMITED when this is used?

@@ +463,3 @@
+    parser.add_argument("--gdb-non-stop", dest="gdb_non_stop",
+                        action="store_true",
+                        help="Run the debugee automatically in gdb (implies
--gdb)")

debugee? "tests" ?

--- Comment #4 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 372392:
 --> (https://bugzilla.gnome.org/review?bug=796389&attachment=372392)

::: validate/launcher/main.py
@@ +460,3 @@
                         action="store_true",
                         help="Run the tests inside gdb (implies"
                         " --output-dir=stdout and --jobs=1)")

Is the test timeout UNLIMITED when this is used?

@@ +463,3 @@
+    parser.add_argument("--gdb-non-stop", dest="gdb_non_stop",
+                        action="store_true",
+                        help="Run the debugee automatically in gdb (implies
--gdb)")

debugee? "tests" ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.