[Bug 796169] vaapidec: Sample video that renders fine with FFMPEG but not in GStreamer

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796169

--- Comment #28 from sreerenj <bsreerenj at gmail.com> ---
(In reply to Nicolas Dufresne (ndufresne) from comment #26)
> I think the logic in find_first_field() is completly flawed.

No, I disagree :)
It was the only way to deal with "first-field" missing case.

> Nothing really
> holds there. We simply match field with different parity, or fill if same.
> We should look at the frame_num.
> 
> If the frame_num is different then current pic, previous pic is a frame and
> only has one field, it's pretty clear a field was lost. Though, I'd need an
> explanation of what is the design here. Why can't we just detect missing
> field like this, and when recurse to process the anctual field that triggered
> that detection ?

Here I don't understand what you are trying to say, sorry.
If you interpreted the frame-num as a monotonically increasing value, then it
is wrong :)
Usually if (previous_frame_is_ref)
  next_frame_frame_num_increments

I P B P P B B
0 1 2 2 3 4 4

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.