[Bug 796452] avdemux:fix memory leak

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=796452

Edward Hervey <bilboed at bilboed.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #372476|none                        |needs-work
             status|                            |

--- Comment #2 from Edward Hervey <bilboed at bilboed.com> ---
Review of attachment 372476:
 --> (https://bugzilla.gnome.org/review?bug=796452&attachment=372476)

::: ext/libav/gstavdemux.c
@@ +1199,3 @@

+  if (tagmap)
+    g_hash_table_unref (tagmap);

You can't do this. That hashtable is meant to be re-used.

The proper fix would be to convert that tagmap to a regular static array
(instead of a dynamicly built one).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.