[Bug 797264] vaapih265dec: Support 422 10bit decode.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797264

--- Comment #11 from Fei <fei.w.wang at intel.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #8)
> Review of attachment 374024 [details] [review]:
> 
> overall it looks good, just a couple library version guards.
> 
> Also, Nicolas already merged the color space definition patches.
> 
> ::: gst-libs/gst/vaapi/gstvaapisurface.h
> @@ +82,3 @@
>    GST_VAAPI_CHROMA_TYPE_RGB16,
> +  GST_VAAPI_CHROMA_TYPE_YUV420_10BPP,
> +  GST_VAAPI_CHROMA_TYPE_YUV422_10BPP
> 
> nitpick: add a comma at the end, thus if a new chroma type is added,
> wouldn't be need to modify the previous line as in this case.
> 
> ::: gst-libs/gst/vaapi/gstvaapiutils.c
> @@ +403,3 @@
>        break;
> +    case VA_RT_FORMAT_YUV422_10:
> +      chroma_type = GST_VAAPI_CHROMA_TYPE_YUV422_10BPP;
> 
> VA_RT_FORMAT_YUV422_10 was defined in VA version of 1.4 so you must guard
> this code around a 
> 
> #if VA_CHECK_VERSION(1,4,0)
> 
> @@ +454,3 @@
>        break;
> +    case GST_VAAPI_CHROMA_TYPE_YUV422_10BPP:
> +      format = VA_RT_FORMAT_YUV422_10;
> 
> same here

Thanks Victor for your reviewing. I checked libva, VA_RT_FORMAT_YUV422_10
actually was defined in version 1.2.0. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.